fix: empty string displayed as SelectDropdown title #3773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davwheat
requested changes
Mar 22, 2023
|
Could we also document what this issue was affecting (e.g., an example of an extension where this was a problem)? |
|
Example of Flarum With this patch: |
Yes, tested locally - all good |
Co-authored-by: David Wheatley <david@davwheat.dev>
imorland
added
type/bug
prio/high
javascript
imorland
added a commit
that referenced
this pull request
Mar 23, 2023
* fix: empty string displayed as SelectDropdown title * chore: remove import * chore: ts-ignore * Update framework/core/js/src/common/components/SelectDropdown.tsx Co-authored-by: David Wheatley <david@davwheat.dev> --------- Co-authored-by: David Wheatley <david@davwheat.dev>
imorland
added a commit
that referenced
this pull request
Mar 23, 2023
* fix: empty string displayed as SelectDropdown title * chore: remove import * chore: ts-ignore * Update framework/core/js/src/common/components/SelectDropdown.tsx Co-authored-by: David Wheatley <david@davwheat.dev> --------- Co-authored-by: David Wheatley <david@davwheat.dev>
imorland
added a commit
that referenced
this pull request
Mar 23, 2023
* fix: empty string displayed as SelectDropdown title * chore: remove import * chore: ts-ignore * Update framework/core/js/src/common/components/SelectDropdown.tsx Co-authored-by: David Wheatley <david@davwheat.dev> --------- Co-authored-by: David Wheatley <david@davwheat.dev>
imorland
added a commit
that referenced
this pull request
Mar 24, 2023
* fix: empty string displayed as SelectDropdown title * chore: remove import * chore: ts-ignore * Update framework/core/js/src/common/components/SelectDropdown.tsx Co-authored-by: David Wheatley <david@davwheat.dev> --------- Co-authored-by: David Wheatley <david@davwheat.dev>
imorland
added a commit
that referenced
this pull request
Mar 24, 2023
* fix: empty string displayed as SelectDropdown title * chore: remove import * chore: ts-ignore * Update framework/core/js/src/common/components/SelectDropdown.tsx Co-authored-by: David Wheatley <david@davwheat.dev> --------- Co-authored-by: David Wheatley <david@davwheat.dev>
Closed
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts the change to using
extractTextintroduced in #3608Whilst using
extractText, the button title is rendered as an empty string. This PR reverts that change so that expected behaviour is restored.Changes proposed in this pull request:
Reviewers should focus on:
Screenshot
Necessity
Confirmed
composer test).Required changes: